refactor: Add ADR for token handling refactor #3734
Merged
+240
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
requested review from
wolf4ood,
ndr-brt,
paullatzelsperger and
bscholtes1A
paullatzelsperger
approved these changes
Dec 22, 2023
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2023-12-19-token-handling-refactor/README.md
Outdated
Show resolved
Hide resolved
wolf4ood
approved these changes
Dec 22, 2023
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
…ctor/README.md Co-authored-by: Paul Latzelsperger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a Decision Record detailing how token handling will be refactored.
Why it does that
Token generation and verification have evolved organically over time and contain a number of inconsistencies and unnecessary complexity.
Linked Issue(s)
Closes #3733